-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control panel expanded state via blueprint APIs #5484
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
added
🟦 blueprint
The data that defines our UI
exclude from changelog
PRs with this won't show up in CHANGELOG.md
include in changelog
and removed
exclude from changelog
PRs with this won't show up in CHANGELOG.md
labels
Mar 12, 2024
Size changes
|
5 tasks
Wumpf
previously requested changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool stuff! there's a typo that needs fixing and I'd like to chat about the archetype structure
crates/re_types/definitions/rerun/blueprint/archetypes/panel_blueprint.fbs
Show resolved
Hide resolved
crates/re_types/definitions/rerun/blueprint/archetypes/panel_blueprint.fbs
Show resolved
Hide resolved
jleibs
added a commit
that referenced
this pull request
Mar 13, 2024
### What - Builds on top of: #5484 - Resolves: #2089 - Specifically the part about the bridge dep on re_viewer. The rest of the decoupling has already been done. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5485/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5485/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5485/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5485) - [Docs preview](https://rerun.io/preview/5189590ca4dc0282a6b1c814200db8434ab7004e/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/5189590ca4dc0282a6b1c814200db8434ab7004e/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
This was referenced Mar 15, 2024
emilk
changed the title
Include blueprint APIs for controlling panel expanded state
Control panel expanded state via blueprint APIs
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🟦 blueprint
The data that defines our UI
include in changelog
🪵 Log & send APIs
Affects the user-facing API for all languages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
These replace the old python_bridge APIs.
Also plumb through some missing components:
Updated the old python blueprint example now that the bridge APIs are gone.
Example code:
Checklist
main
build: app.rerun.ionightly
build: app.rerun.io