More context menu 6: Add "Expand/Collapse all" actions #5433
Conversation
| // TODO(ab): in an ideal world, we'd check the fully expended/collapsed state of the item to | ||
| // avoid showing a command that wouldn't have an effect but that's lots of added complexity. |
There was a problem hiding this comment.
yeah whatever, not a big issue I think
| // avoid showing a command that wouldn't have an effect but that's lots of added complexity. | ||
| match item { | ||
| Item::StoreId(_) | Item::ComponentPath(_) => false, | ||
| Item::SpaceView(_) | Item::Container(_) | Item::InstancePath(_) => true, |
There was a problem hiding this comment.
~could we check if either of these are empty like we do with data result? 🤔 ~
Right, spaceview and container are never empty. InstancePath might, you could check the global path tree for that, might get too involved quickly though
There was a problem hiding this comment.
Well, containers can be empty, but they always have the triangle icon (which is kinda weird, if you think of it, but I guess more natural given that they are meant to contain something).
As for Instance paths, they are never empty, since they always have at least some components. When they show up in the blueprint tree, then they are DataResult and this case is properly handled.
I'll do that in the next/final PR in that series: split release checklist and |
### What NOTE: review commit by commit (first commit is pure refactoring). Final PR in the series. This PR: - split `actions.rs` into many sub-files - fix capitalisation in some menu item - split the release check list in small checks Full series: - #5392 - #5397 - #5407 - #5411 - #5422 - #5433 - #5456 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5456/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5456/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5456/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5456) - [Docs preview](https://rerun.io/preview/a36360f586494f6648fdc4bbb9d806ab12911358/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/a36360f586494f6648fdc4bbb9d806ab12911358/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
What
What the title says ☝🏻
expand_collapse.mp4
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io