Fix parents of queried paths getting visualized, fix 2D objects not showing at all in 3D if their camera parent is not included #5424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The is about
tree_prefix_only
(formerdirect_included
, inverted now) not causing visualizer gathering to stop.We now also grey out everything that doesn't have a visualizer in the blueprint hierarchy. Debatable whether that should be just tree prefixes (i.e. could instead not grey out if a result is the query but doesn't have a visualizer?). I found this behavior nicer since "not having visualizer" is equivalent to being invisible (which also causes greying out)
long story short:
pinhole_image_plane_distance
would default to 0.0 if the camera is not present. Bandaid is to make it default to 1.0 which is better anyways. Hoping this will be solved better onceEntityProperties
is gone.Checklist
main
build: app.rerun.ionightly
build: app.rerun.io