Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parents of queried paths getting visualized, fix 2D objects not showing at all in 3D if their camera parent is not included #5424

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 7, 2024

What

Fix parents of queried paths getting visualized

The is abouttree_prefix_only (former direct_included, inverted now) not causing visualizer gathering to stop.
We now also grey out everything that doesn't have a visualizer in the blueprint hierarchy. Debatable whether that should be just tree prefixes (i.e. could instead not grey out if a result is the query but doesn't have a visualizer?). I found this behavior nicer since "not having visualizer" is equivalent to being invisible (which also causes greying out)

fix 2D objects not showing at all in 3D if their camera parent is not included

long story short: pinhole_image_plane_distance would default to 0.0 if the camera is not present. Bandaid is to make it default to 1.0 which is better anyways. Hoping this will be solved better once EntityProperties is gone.

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release include in changelog labels Mar 7, 2024
@Wumpf Wumpf merged commit 9f65a12 into main Mar 8, 2024
34 of 39 checks passed
@Wumpf Wumpf deleted the andreas/pure-treeprefix branch March 8, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants