Key-less datamodel 1: scrap InstanceKey
from public logging APIs
#5395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just removes
InstanceKey
s from the archetypes where they were exposed, and updates all tests/examples/APIs/etc accordingly.Nothing else changes. Internally, everything is still driven by autogenerated instance keys.
The
num_instances
field and the associated log-time check ("0, 1, or N?") are still there.Part of a series of PR to migrate to a key-less, PoV-less, component-based (as opposed to archetype-based) query model:
InstanceKey
from public logging APIs #5395Checklist
main
build: app.rerun.ionightly
build: app.rerun.io