Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key-less datamodel 1: scrap InstanceKey from public logging APIs #5395

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Mar 5, 2024

This just removes InstanceKeys from the archetypes where they were exposed, and updates all tests/examples/APIs/etc accordingly.

Nothing else changes. Internally, everything is still driven by autogenerated instance keys.

The num_instances field and the associated log-time check ("0, 1, or N?") are still there.


Part of a series of PR to migrate to a key-less, PoV-less, component-based (as opposed to archetype-based) query model:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@teh-cmc teh-cmc added 🐍 Python API Python logging API 🦀 Rust API Rust logging API 🚜 refactor Change the code, not the functionality 🌊 C++ API C/C++ API specific include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages labels Mar 5, 2024
@teh-cmc teh-cmc marked this pull request as ready for review March 5, 2024 10:11
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no turning back now, let's do this!

@teh-cmc teh-cmc merged commit a79bcf8 into main Mar 5, 2024
47 of 51 checks passed
@teh-cmc teh-cmc deleted the cmc/keyless_1_no_more_key_logging branch March 5, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌊 C++ API C/C++ API specific 🔩 data model include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages 🐍 Python API Python logging API 🚜 refactor Change the code, not the functionality 🦀 Rust API Rust logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants