Introduce python serialization for ContainerBlueprint #5390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
changed the title
jleibs
added
🐍 Python API
jleibs
force-pushed
the
jleibs/container_blueprint_serialize
branch
from
6c2fa96 to
84aafb6
Compare
jleibs
changed the base branch from
andreas/serializable-included-space-view2
to
main
Wumpf
requested changes
Mar 5, 2024
There was a problem hiding this comment.
some confusion around aliases and float/double. Otherwise looks good! Your test makes a little bit more sense than the ones I have - I should also feed in more arrays with the component type already provided.
We'll have to fix the grid stuff first ofc as well as you pointed out
crates/re_types/definitions/rerun/blueprint/components/column_share.fbs
Outdated
Show resolved
Hide resolved
| "attr.rerun.scope": "blueprint", | ||
| "attr.rust.derive": "Default, PartialEq, Eq, PartialOrd, Ord", | ||
| "attr.rust.repr": "transparent" | ||
| "attr.rust.repr": "transparent", | ||
| "attr.rust.tuple_struct" |
There was a problem hiding this comment.
I'm surprised we don't have a python alias defined here, I got mypy errors when I didn't put bool in there explicitely
There was a problem hiding this comment.
I think this is something that come over partially from the cherry-pick
crates/re_types/definitions/rerun/blueprint/components/included_content.fbs
Show resolved
Hide resolved
crates/re_types/definitions/rerun/blueprint/components/row_share.fbs
Outdated
Show resolved
Hide resolved
| let mandatory_docstring = format!( | ||
| r#""""Extension for [{name}][rerun.{kind}.{name}].""""#, | ||
| r#""""Extension for [{name}][rerun.{scope}{kind}.{name}].""""#, |
There was a problem hiding this comment.
ah good fix, I just yielded to the broken version so far
rerun_py/rerun_sdk/rerun/blueprint/components/column_share_ext.py
Outdated
Show resolved
Hide resolved
jleibs
force-pushed
the
jleibs/container_blueprint_serialize
branch
from
84aafb6 to
007b5cd
Compare
5 tasks
jleibs
added a commit
that referenced
this pull request
Mar 5, 2024
### What Plus the usual amount of plumbing, following overall similar patterns than the previous PRs in this area * Sister PR to #5390 * Part of #4167 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5401/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5401/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5401/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5401) - [Docs preview](https://rerun.io/preview/4095985db6d11b3625e845b512983983c0bbea7a/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/4095985db6d11b3625e845b512983983c0bbea7a/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Jeremy Leibs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Cherry-picked over the Name / Visibillity changes from
andreas/serializable-spaceviewblueprint, so we'll need to navigate merge conflicts there.Standard implementation of serializers and a unit-test for them:
After talking to @Wumpf I moved some of the list-types up a level to simplify the serialization code, but this raised an issue with mismatched dimensions. Need to discuss if we want to remove this check (in light of the instance-key simplification), or push things back down to mono-components with internal lists.
TODO
WrongNumberOfInstances#5399Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io