Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge example page into welcome screen #5329

Merged
merged 15 commits into from
Feb 29, 2024
Merged

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented Feb 28, 2024

What

Changes:

  • Updated design of thumbnails on example page to match https://rerun.io/examples
  • Updated some spacing on welcome screen to better match design from Welcome + Examples screen design touch-ups #3244
  • Remove loading spinners on example page thumbnails
  • Remove tabs on welcome screen + remove the examples welcome screen card + the whole mechanism of switching between the welcome screen and example page
  • Move example page contents below welcome screen
  • If example page is not visible, indicate their presence with a floating See examples button, which may be clicked to scroll the examples page into view

I have not done anything to change the loading behavior, or added any extra effects as the example page loads in. There are also a few things in #4961 not done in this PR, such as updating the copy or merging the quick start examples.

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@jprochazk
Copy link
Member Author

First pass at updating the example page styles:
image

It's not exactly the same as https://rerun.io/examples, because we want to keep the size of each example, and I couldn't think of a better place to put it.

@jprochazk jprochazk changed the title Move examples into welcome screen Update example page design Feb 29, 2024
@jprochazk jprochazk added ui concerns graphical user interface include in changelog labels Feb 29, 2024
@jprochazk jprochazk changed the title Update example page design Merge example page into welcome screen Feb 29, 2024
@jprochazk jprochazk marked this pull request as ready for review February 29, 2024 16:02
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a great improvement!

Code generally lgtm, with a few minor comments.

crates/re_ui/data/icons/arrow_down.png Outdated Show resolved Hide resolved
crates/re_viewer/src/ui/welcome_screen/example_page.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/ui/welcome_screen/example_page.rs Outdated Show resolved Hide resolved
@jprochazk
Copy link
Member Author

jprochazk commented Feb 29, 2024

  • Changed the Page in ExamplePage and WelcomePage to Section, and updated all references. The whole container is still called WelcomeScreen.
  • Did some minor refactoring of the panel buttons in the welcome section, there was some code leftover which was previously used for switching to the example page.
  • Updated the icon to 28x28 px

@jprochazk jprochazk merged commit 1643db8 into main Feb 29, 2024
34 checks passed
@jprochazk jprochazk deleted the jan/welcome-screen-tweaks branch February 29, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Welcome + Examples screen design touch-ups
2 participants