Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resetting vertical axis when using non-uniform zoom on Time Series #5287

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Feb 26, 2024

What

@Reviewer: Best to try it yourself, took a fair bit of time to get the desired behavior in (presumably) all cases.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself include in changelog labels Feb 26, 2024
@jleibs
Copy link
Member

jleibs commented Feb 26, 2024

Trying this out myself, I see two issues:

  1. If I've messed around with the range and then I click "Lock Range", in the selection panel the range does not become locked to the intended value. I have to double-click to now get it to jump to the locked range.
  2. When the range is locked I can still pan vertically, even though scroll vertically is disabled.

Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still makes me sad how complex this feels, but it overall makes sense and seems to be a net improvement! Thanks!

@Wumpf Wumpf merged commit 1d72d26 into main Feb 26, 2024
40 checks passed
@Wumpf Wumpf deleted the andreas/fix-vertical-zoom-behavior-on-timeseries branch February 26, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time series view's nonuniform zoom action resets vertical axis
2 participants