Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix banding artifacts of 3D space view's skybox #5279

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Feb 26, 2024

What

Add simple algebraic (doesn't need a texture lookup) dithering to 3D generic skybox in order to fix banding artifacts.
Depending on your screen and screen calibration you may or may not have been annoyed by this in the past (on most of the setups I use it's quite glaring)

Before:
image

After:
image

Note the ring artifacts which are mostly gone on the second screenshot - if you can't spot the difference, make sure to look at the screenshots without any scaling with your screen at high brightness relative to your surroundings

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added enhancement New feature or request 🔺 re_renderer affects re_renderer itself include in changelog labels Feb 26, 2024
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

EDIT I actually ran it and compared and OMG IT IS SO MUCH NICER

crates/re_renderer/shader/generic_skybox.wgsl Outdated Show resolved Hide resolved
crates/re_renderer/shader/generic_skybox.wgsl Show resolved Hide resolved
Wumpf and others added 2 commits February 26, 2024 11:46
Co-authored-by: Emil Ernerfeldt <[email protected]>
@Wumpf
Copy link
Member Author

Wumpf commented Feb 26, 2024

EDIT I actually ran it and compared and OMG IT IS SO MUCH NICER

crazy isn't it 😄
There's still some slight less-clear-cut banding visible under movement for me. I wonder if that's just my screen of if the level calculation isn't entirely correct, but it made sense to me.

@Wumpf Wumpf merged commit c123c59 into main Feb 26, 2024
32 of 34 checks passed
@Wumpf Wumpf deleted the andreas/skybox-dithering branch February 26, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request include in changelog 🔺 re_renderer affects re_renderer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants