Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query caching for pinhole querying in transform context #5271

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Feb 24, 2024

What

Didn't make a big difference in perf though for the scene I tested with (opf --no-frames), but no point in not keeping it, likely more relevant for more even more pinholes.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added 🚀 performance Optimization, memory use, etc 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Feb 24, 2024
@@ -321,6 +318,27 @@ fn get_cached_transform(
transform3d
}

fn get_cached_pinhole(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not change the implementation of query_pinole to use the cache instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ripples too much right now and didn't want to have that in this PR.
Actually many callsites of query_pinhole only want to know about whether the component exist, so they shouldn't do the full query (go to EntityTree instead!)

@Wumpf Wumpf merged commit f47f41e into main Feb 26, 2024
40 checks passed
@Wumpf Wumpf deleted the andreas/cached-pinhole-query branch February 26, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚀 performance Optimization, memory use, etc 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants