-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Context menu 4: add "Clone space view" action #5265
Conversation
Mmm I get some weird behaviour with opf (after bp reset): the cloned space view ends up in a newly created grid container 🤔 Edit: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mutex handling indeed doesn't make sense to me. Everything else checks out (:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much better :)
What
This PR adds "Clone Space View" to the context menu (when clicking a single space view). Also, now the the cloned space view appears just after the original space view, in the same container (previously it would typically appear at the end of the root container regardless of the position of the original space view).
This PR also unearthed a bug that I'm surprised didn't surface earlier. The effect of
mark_user_interaction
wasn't visible until the next frame, as the value was only saved to blueprint, and not cached in theViewportBlurprint
. This could lead to an issue whenTreeAction
are processed end-of-frame and exposed to the "old"mark_user_interaction
flag values (namely: unwanted reset of the tree). Those flags are nowMutex
es (to gain interior mutability)AtomicBool
s and updated in place (in addition to being saved to blueprint like before). cc @jleibspart of:
Checklist
main
build: app.rerun.ionightly
build: app.rerun.io