Skip to content

Clear all blueprints in RAM and on disk when clicking "Reset Viewer" #5199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 15, 2024
Merged

Clear all blueprints in RAM and on disk when clicking "Reset Viewer" #5199

merged 4 commits into from
Feb 15, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Feb 15, 2024 •
edited by github-actions bot
Loading

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@emilk emilk added 🧑‍💻 dev experience developer experience (excluding CI) include in changelog 📺 re_viewer affects re_viewer itself labels Feb 15, 2024
@Wumpf Wumpf self-requested a review February 15, 2024 09:54
Wumpf
Wumpf approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@emilk emilk merged commit 5c7dabe into main Feb 15, 2024
@emilk emilk deleted the emilk/reset-viewer branch February 15, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🧑‍💻 dev experience developer experience (excluding CI) include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reset Viewer should clear blueprint stuff too
2 participants
@emilk @Wumpf