Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect minimum supported rust version mentioned in docs and examples #5195

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Fix incorrect minimum supported rust version mentioned in docs and examples #5195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clippy.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# -----------------------------------------------------------------------------
# Section identical to the main scripts/clippy_wasm/clippy.toml:

msrv = "1.72"
msrv = "1.74"

allow-unwrap-in-tests = true

Expand Down
2 changes: 1 addition & 1 deletion crates/re_viewer/data/quick_start_guides/rust_connect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Let's try it out in a brand-new Rust project:
cargo init cube && cd cube && cargo add rerun --features native_viewer
```

Note that the Rerun SDK requires a working installation of Rust 1.72+.
Note that the Rerun SDK requires a working installation of Rust 1.74+.

## Logging your own data

Expand Down
2 changes: 1 addition & 1 deletion crates/re_viewer/data/quick_start_guides/rust_spawn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Let's try it out in a brand-new Rust project:
cargo init cube && cd cube && cargo add rerun
```

Note that the Rerun SDK requires a working installation of Rust 1.72+.
Note that the Rerun SDK requires a working installation of Rust 1.74+.

## Logging your own data

Expand Down
2 changes: 1 addition & 1 deletion docs/content/getting-started/installing-viewer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Generally, you should make sure that your SDK version matches the version of the
There are many ways to install the viewer. Please pick whatever works best for your setup:

* `cargo binstall rerun-cli` - download binaries via [`cargo binstall`](https://github.com/cargo-bins/cargo-binstall)
* `cargo install rerun-cli` - build it from source (this requires Rust 1.72+)
* `cargo install rerun-cli` - build it from source (this requires Rust 1.74+)
* Download it from the [GitHub Release artifacts](https://github.com/rerun-io/rerun/releases/latest/)
* Together with the Rerun [Python SDK](python.md):
* `pip3 install rerun-sdk` - download it via pip
Expand Down
2 changes: 1 addition & 1 deletion docs/content/getting-started/rust.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ order: 3
---

## Setup
The Rerun SDK for Rust requires a working installation of Rust 1.72+.
The Rerun SDK for Rust requires a working installation of Rust 1.74+.

After you have [installed the viewer](installing-viewer.md) you can simply add [the rerun crate](https://crates.io/crates/rerun) to your project with `cargo add rerun`.

Expand Down
2 changes: 1 addition & 1 deletion examples/rust/clock/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "clock"
version = "0.14.0-alpha.1+dev"
edition = "2021"
rust-version = "1.72"
rust-version = "1.74"
license = "MIT OR Apache-2.0"
publish = false

Expand Down
2 changes: 1 addition & 1 deletion examples/rust/custom_data_loader/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "custom_data_loader"
version = "0.14.0-alpha.1+dev"
edition = "2021"
rust-version = "1.72"
rust-version = "1.74"
license = "MIT OR Apache-2.0"
publish = false

Expand Down
2 changes: 1 addition & 1 deletion examples/rust/custom_space_view/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "custom_space_view"
version = "0.14.0-alpha.1+dev"
edition = "2021"
rust-version = "1.72"
rust-version = "1.74"
license = "MIT OR Apache-2.0"
publish = false

Expand Down
2 changes: 1 addition & 1 deletion examples/rust/custom_store_subscriber/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "custom_store_subscriber"
version = "0.14.0-alpha.1+dev"
edition = "2021"
rust-version = "1.72"
rust-version = "1.74"
license = "MIT OR Apache-2.0"
publish = false

Expand Down
2 changes: 1 addition & 1 deletion examples/rust/dna/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "dna"
version = "0.14.0-alpha.1+dev"
edition = "2021"
rust-version = "1.72"
rust-version = "1.74"
license = "MIT OR Apache-2.0"
publish = false

Expand Down
2 changes: 1 addition & 1 deletion examples/rust/extend_viewer_ui/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "extend_viewer_ui"
version = "0.14.0-alpha.1+dev"
edition = "2021"
rust-version = "1.72"
rust-version = "1.74"
license = "MIT OR Apache-2.0"
publish = false

Expand Down
2 changes: 1 addition & 1 deletion examples/rust/external_data_loader/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "rerun-loader-rust-file"
version = "0.14.0-alpha.1+dev"
edition = "2021"
rust-version = "1.72"
rust-version = "1.74"
license = "MIT OR Apache-2.0"
publish = false

Expand Down
2 changes: 1 addition & 1 deletion examples/rust/minimal/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "minimal"
version = "0.14.0-alpha.1+dev"
edition = "2021"
rust-version = "1.72"
rust-version = "1.74"
license = "MIT OR Apache-2.0"
publish = false

Expand Down
2 changes: 1 addition & 1 deletion examples/rust/minimal_options/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "minimal_options"
version = "0.14.0-alpha.1+dev"
edition = "2021"
rust-version = "1.72"
rust-version = "1.74"
license = "MIT OR Apache-2.0"
publish = false

Expand Down
2 changes: 1 addition & 1 deletion examples/rust/minimal_serve/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "minimal_serve"
version = "0.14.0-alpha.1+dev"
edition = "2021"
rust-version = "1.72"
rust-version = "1.74"
license = "MIT OR Apache-2.0"
publish = false

Expand Down
2 changes: 1 addition & 1 deletion examples/rust/objectron/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "objectron"
version = "0.14.0-alpha.1+dev"
edition = "2021"
rust-version = "1.72"
rust-version = "1.74"
license = "MIT OR Apache-2.0"
publish = false

Expand Down
2 changes: 1 addition & 1 deletion examples/rust/raw_mesh/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "raw_mesh"
version = "0.14.0-alpha.1+dev"
edition = "2021"
rust-version = "1.72"
rust-version = "1.74"
license = "MIT OR Apache-2.0"
publish = false

Expand Down
2 changes: 1 addition & 1 deletion examples/rust/shared_recording/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "shared_recording"
version = "0.14.0-alpha.1+dev"
edition = "2021"
rust-version = "1.72"
rust-version = "1.74"
license = "MIT OR Apache-2.0"
publish = false

Expand Down
2 changes: 1 addition & 1 deletion examples/rust/spawn_viewer/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "spawn_viewer"
version = "0.14.0-alpha.1+dev"
edition = "2021"
rust-version = "1.72"
rust-version = "1.74"
license = "MIT OR Apache-2.0"
publish = false

Expand Down
2 changes: 1 addition & 1 deletion examples/rust/stdio/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "stdio"
version = "0.14.0-alpha.1+dev"
edition = "2021"
rust-version = "1.72"
rust-version = "1.74"
license = "MIT OR Apache-2.0"
publish = false

Expand Down
2 changes: 1 addition & 1 deletion examples/rust/template/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "template"
version = "0.14.0-alpha.1+dev"
edition = "2021"
rust-version = "1.72"
rust-version = "1.74"
license = "MIT OR Apache-2.0"
publish = false

Expand Down
4 changes: 2 additions & 2 deletions rerun_py/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,10 @@ You can run with `RUST_LOG=debug` to get more output out of the rerun SDK.
If you are using an Apple-silicon Mac, make sure `rustc -vV` outputs `host: aarch64-apple-darwin`. If not, this should fix it:

``` sh
rustup set default-host aarch64-apple-darwin && rustup install 1.72
rustup set default-host aarch64-apple-darwin && rustup install 1.74
```

If you want to switch back, this is how:
``` sh
rustup set default-host x86_64-apple-darwin && rustup install 1.72
rustup set default-host x86_64-apple-darwin && rustup install 1.74
```
2 changes: 1 addition & 1 deletion scripts/clippy_wasm/clippy.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
# -----------------------------------------------------------------------------
# Section identical to the main clippy.toml:

msrv = "1.72"
msrv = "1.74"

allow-unwrap-in-tests = true

Expand Down
2 changes: 1 addition & 1 deletion scripts/lint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@ def test_lint_workspace_deps() -> None:
name = "clock"
version = "0.6.0-alpha.0"
edition = "2021"
rust-version = "1.72"
rust-version = "1.74"
license = "MIT OR Apache-2.0"
publish = false

Expand Down
2 changes: 1 addition & 1 deletion tests/rust/plot_dashboard_stress/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "plot_dashboard_stress"
version = "0.14.0-alpha.1+dev"
edition = "2021"
rust-version = "1.72"
rust-version = "1.74"
license = "MIT OR Apache-2.0"
publish = false

Expand Down
Loading