Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up time range ui #5089

Merged
merged 10 commits into from
Feb 7, 2024
Merged

Clean up time range ui #5089

merged 10 commits into from
Feb 7, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Feb 7, 2024

What

Review commit by commit.

Brevity is the soul of a good UI.

Before

image
image

After

image
image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@emilk emilk added ui concerns graphical user interface include in changelog labels Feb 7, 2024
@Wumpf Wumpf self-requested a review February 7, 2024 13:28
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sooo much better <3

it's actually short enough now to not default minimize it.

default on first interaction:

image

expanded:
image

so might as well keep it open now imho :)

One problem we still have is that the default selection panel (reset viewer!) is not wide enough for this selection:
image

maybe current time + offset? instead

crates/re_viewer/src/ui/visible_history.rs Outdated Show resolved Hide resolved
emilk and others added 2 commits February 7, 2024 14:36
@emilk emilk merged commit 48ac894 into main Feb 7, 2024
40 checks passed
@emilk emilk deleted the emilk/ui-tweaks branch February 7, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants