Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cached 2D & 3D arrow clouds #5088

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Cached 2D & 3D arrow clouds #5088

merged 3 commits into from
Feb 7, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Feb 7, 2024

Grunt work to make arrow clouds go through the cached APIs.

Performance comparison

Using the clock example, with the minutes hand set to -inf:+inf.

main:
image

now:
image


TODO:

  • self-review
  • check doc examples still work
    • arrow2d_simple
    • arrow3d_simple
  • perf comparison

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@teh-cmc teh-cmc added 🔍 re_query affects re_query itself 🚀 performance Optimization, memory use, etc include in changelog labels Feb 7, 2024
@teh-cmc teh-cmc marked this pull request as ready for review February 7, 2024 13:37
@Wumpf Wumpf self-requested a review February 7, 2024 15:02
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

another great "free" speedup, not bad!

@Wumpf Wumpf merged commit ef0557e into main Feb 7, 2024
40 checks passed
@Wumpf Wumpf deleted the cmc/cached_arrows branch February 7, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🚀 performance Optimization, memory use, etc 🔍 re_query affects re_query itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants