-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RERUN_FLUSH_NUM_BYTES
and data size estimations
#5086
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
force-pushed
the
emilk/fix-size-flushing
branch
from
February 7, 2024 11:10
edb9231
to
cce127d
Compare
emilk
added
🪳 bug
Something isn't working
😤 annoying
Something in the UI / SDK is annoying to use
labels
Feb 7, 2024
emilk
changed the title
Emilk/fix size flushing
Fix Feb 7, 2024
RERUN_FLUSH_NUM_BYTES
and data size estimations
Size changes
|
⬆ this means it is working! |
teh-cmc
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
😤 annoying
Something in the UI / SDK is annoying to use
🪳 bug
Something isn't working
include in changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
DataRow.total_size_bytes
is wrong, soRERUN_FLUSH_NUM_BYTES
doesn't work, leading to huge messages in our example .rrds #5078The first commit is the actual fix: the size calculations were completely wrong for fixed-size array and
SmallVec
, leading the batcher to severely under-counting how many bytes it had processed, leading it to effectively ignoreRERUN_FLUSH_NUM_BYTES
, which in turn lead to example .rrds which big batches of data, which streams poorly.Checklist
main
build: app.rerun.ionightly
build: app.rerun.io