Clear empty containers after tile drag-and-drop #5044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abey79
added
ui
jleibs
approved these changes
Feb 5, 2024
teh-cmc
changed the title
abey79
added a commit
that referenced
this pull request
Feb 6, 2024
abey79
added a commit
that referenced
this pull request
Feb 6, 2024
### What - Fixes #5061 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5064/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5064/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5064/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/5064) - [Docs preview](https://rerun.io/preview/da3ca8a3ebf53647a43095c403a63b61007417c6/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/da3ca8a3ebf53647a43095c403a63b61007417c6/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR triggers a egui_tile tree simplification of the viewport upon tile drag-and-drop to work around the spurious empty containers typically left behind after a move. This happens only when the additive workflow feature flag is set (otherwise, the on-going simplification takes care of that).
This simplification is agressive, and may delete (empty) containers that the user created on purpose, which is why we run it only on drag-and-drop. This is not ideal, but that's the best I can come up with until we stop using egui_tiles as application-level data structure. Still a net usability win.
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io