Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Visible Time Range higher in the Selection Panel #5036

Merged
merged 6 commits into from
Feb 6, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Feb 5, 2024

What

This PR:

  • moves Visible Time Range up in the Selection Panel
  • defaults Visible Time Range to collapsed
  • moves the temporal vs. sequence string to the hover tooltip

Before / After (default) / After (uncollapsed)

image image image

Hover

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@abey79 abey79 marked this pull request as ready for review February 5, 2024 10:53
@abey79 abey79 added ui concerns graphical user interface include in changelog labels Feb 5, 2024
Base automatically changed from antoine/fix-vh-display-bug to main February 6, 2024 07:54
crates/re_viewer/src/ui/visible_history.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/ui/visible_history.rs Outdated Show resolved Hide resolved
Visible Time Range properties are stored separately of each _types_ of timelines. The may differ depending on \
whether the current timeline is temporal or a sequence. The current settings apply to all {} timelines.

Notes that the data current as of the time range starting time is included.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vote to completely remove that part

abey79 and others added 3 commits February 6, 2024 09:22
@abey79 abey79 merged commit 16ff8bc into main Feb 6, 2024
40 checks passed
@abey79 abey79 deleted the antoine/visible-history-on-top branch February 6, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants