-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a new blueprint archetype for AxisY configuration in a plot. #5028
Conversation
Doesn't play nice with the manual single-axis zoom on scroll + ctrl + alt: It jumps into a previous zoom level and goes from there but doesn't change the blueprint setting as expected |
Ahh, I should use the active range when doing that single axis zoom. But, I don't think I would expect it to change the blueprint as a result. |
crates/re_types/definitions/rerun/blueprint/archetypes/axis_y.fbs
Outdated
Show resolved
Hide resolved
crates/re_types/definitions/rerun/blueprint/components/zoom_behavior.fbs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting compromise, easier to understand for sure. There's one small remaining issue but we can take that later:
- set a y range
- don't lock zoom
- move the plot beyond the camera
- do ctrl+alt zooming: It now jumps to the y previously range in manner it should only do on double click
not a biggy, I doubt lot of people are discovering ctrl+alt to begin with
With locked axis I can no longer scroll left-right with my trackpad. Also can't area-zoom by right click + drag (we talked about changing the default box zoom in this case so that the box would extend for the full y-range when y-axis is locked) |
repros for me! when I tested I clicked on it, but track pad without clicking is broken indeed! |
Ahh, didn't even realize trackpad horizontal scrolling was a thing I'm using a mouse where scroll is vertical and shift+scroll is horizontal. I disabled scrolling because I thought it was only vertical and leads to an annoying "bounce." I also disabled the rectangular drag (noted in the ? menu) because there's not a way to make it full range without deep plot-surgery. |
if lock_y_during_zoom { | ||
ui.input_mut(|i| i.smooth_scroll_delta.y = 0.0); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't that mean the scroll delta is zero everywhere?
hm, doesn't seem to affect anything else. okay
What
Part of
Introduce a new archetype for AxisY configuration in a plot.
This contains 2 new components:
In "LockRange" mode, the Y-axis of the plot will always be locked to the defined range, regardless of whether the range is Auto or a specified range.
In the default mode, the user can zoom arbitrarily in a way that preserves the aspect ratio of the data. When the user resets the view, it will return to the defined range.
Checklist
main
build: app.rerun.ionightly
build: app.rerun.io