Introduce a new StrokeWidth component and use it for SeriesLine #5025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
added
ui
Wumpf
approved these changes
Feb 4, 2024
There was a problem hiding this comment.
I'm a bit unsure if this is actually a radius for the line? Haven't checked in-depth. Just assuming it's right ;)
Initially, I wanted this to be a UiSize, but I see how that's too narrow StrokeWidth will do! Although I'm still pondering whether it should be StrokeWidthUi 🤔
| @@ -243,6 +243,53 @@ fn default_marker_shape( | |||
|
|
|||
| // ---- | |||
|
|
|||
| #[allow(clippy::too_many_arguments)] | |||
| fn edit_stroke_width_ui( | |||
There was a problem hiding this comment.
it would be nice to have a module per editor
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
What the title says.
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io