Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the UI for the entity query #5022

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Improve the UI for the entity query #5022

merged 2 commits into from
Feb 2, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Feb 2, 2024

What

This PR implements the minimal sets of UI touch up to make the new query editor releasable.
Note: both commits best reviewed separately (first one is pure refactor)

Query DSL feature flag off

image image

Query DSL feature flag on

image image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@abey79 abey79 added ui concerns graphical user interface include in changelog labels Feb 2, 2024
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting / reorganizing. Much easier to follow.

@abey79 abey79 merged commit 7981b5d into main Feb 2, 2024
41 of 43 checks passed
@abey79 abey79 deleted the antoine/sv-query-touch-up branch February 2, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add/remove entity and query editor improvement
2 participants