Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When loading a .ply file, warn about ignored properties #4934

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Jan 29, 2024

What

A .ply file can contain a lot of stuff, but we only support some of it.

This PR adds warning to the user about everything that was in the .ply file but couldn't be loaded (e.g. triangle faces, point normals, etc).

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@emilk emilk added 📺 re_viewer affects re_viewer itself include in changelog labels Jan 29, 2024
@emilk emilk merged commit ce1a096 into main Jan 29, 2024
42 checks passed
@emilk emilk deleted the emilk/ply-loader-tweaks branch January 29, 2024 13:16
@teh-cmc teh-cmc changed the title When loading a .ply file, warn about ignored fields When loading a .ply file, warn about ignored properties Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants