-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random walk series for plot benchmarks #4903
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolausWest
added
🚀 performance
Optimization, memory use, etc
exclude from changelog
PRs with this won't show up in CHANGELOG.md
labels
Jan 25, 2024
teh-cmc
force-pushed
the
niko/add-series-type-to-benchmark
branch
from
January 25, 2024 12:43
ec396e1
to
799cf84
Compare
4 tasks
teh-cmc
added a commit
that referenced
this pull request
Jan 25, 2024
⚠️ [Try it live!](https://app.rerun.io/pr/4865/index.html?url=https://storage.googleapis.com/rerun-builds/pull_request/4865/plot_gauss2.rrd) :warning: Make it so users can configure an aggregation strategy in the rare case where they either have so much data or are so zoomed out that most of their plot results in an overdraw blurb. Because this builds on top of the range cache, the data is neatly laid out in a memory slice already so this is very cheap to compute. In my tests, the `MinMax` strategy has worked so well that I've decided to make it the default in the end... That might be controversial :no_mouth:. `Off` vs. `MinMax`, using the [new gaussian walk benchmark](#4903): ![image (26)](https://github.com/rerun-io/rerun/assets/2910679/1811becb-d213-44bb-87ea-0e4a7fa058ad) ![image (27)](https://github.com/rerun-io/rerun/assets/2910679/b8d66c92-8719-4de5-a3cb-72c2ea4b1e96) - Fixes #4271 - DNR: requires #4856
teh-cmc
force-pushed
the
niko/add-series-type-to-benchmark
branch
from
January 25, 2024 18:03
799cf84
to
c3ce11c
Compare
Saving a gaussian random walk to fileArgs:
Python:
Rust:
C++:
|
teh-cmc
approved these changes
Jan 26, 2024
teh-cmc
changed the title
Random walk series for plot benchmark in python
Random walk series for plot benchmarks
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
exclude from changelog
PRs with this won't show up in CHANGELOG.md
🚀 performance
Optimization, memory use, etc
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a "Gaussian Random Walk" method to the plot dashboard benchmark.
Also fixes "sim_time" to be in seconds and be consistent with the frequency argument.
just py-plot-dashboard --num-plots 10 --num-series-per-plot 5 --num-points-per-series 5000 --freq 1000 --series-type gaussian-random-walk --save plot_gauss_py.rrd
just py-plot-dashboard --num-plots 10 --num-series-per-plot 5 --num-points-per-series 5000 --freq 1000 --series-type sin-uniform --save plot_uniform_py.rrd
just rs-plot-dashboard --num-plots 10 --num-series-per-plot 5 --num-points-per-series 5000 --freq 1000 --series-type gaussian-random-walk --save plot_gauss_rs.rrd
just rs-plot-dashboard --num-plots 10 --num-series-per-plot 5 --num-points-per-series 5000 --freq 1000 --series-type sin-uniform --save plot_uniform_rs.rrd
just cpp-plot-dashboard --num-plots 10 --num-series-per-plot 5 --num-points-per-series 5000 --freq 1000 --series-type gaussian-random-walk --save plot_gauss_cpp.rrd
just cpp-plot-dashboard --num-plots 10 --num-series-per-plot 5 --num-points-per-series 5000 --freq 1000 --series-type sin-uniform --save plot_uniform_cpp.rrd
Checklist
main
build: app.rerun.ionightly
build: app.rerun.io