Migrate from egui_Tile::TileId
to proper blueprint IDs in ViewportBlueprint
API
#4900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The PR removes many instances of
egui_tiles::TileId
in theViewport
/ViewportBlueprint
/SpaceViewBlueprint
/ContainerBlueprint
APIs, replacing them bySpaceViewId
andContainerId
as appropriate. It also adds some new APIs to support operations previously performed via the tile tree.This PR also removes the
legacy_container_blueprint
feature flag (was added for 0.12 and has been defaulting tofalse
for a while).Note that much of the actual data mutation is still done via tile tree and synchronised back to the blueprint store. This should be further improved in the future.
Checklist
main
build: app.rerun.ionightly
build: app.rerun.io