Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from egui_Tile::TileId to proper blueprint IDs in ViewportBlueprint API #4900

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Jan 24, 2024

What

The PR removes many instances of egui_tiles::TileId in the Viewport/ViewportBlueprint/SpaceViewBlueprint/ContainerBlueprint APIs, replacing them by SpaceViewId and ContainerId as appropriate. It also adds some new APIs to support operations previously performed via the tile tree.

This PR also removes the legacy_container_blueprint feature flag (was added for 0.12 and has been defaulting to false for a while).

Note that much of the actual data mutation is still done via tile tree and synchronised back to the blueprint store. This should be further improved in the future.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@abey79 abey79 added 🚜 refactor Change the code, not the functionality include in changelog labels Jan 24, 2024
@abey79 abey79 requested a review from jleibs January 24, 2024 17:14
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 thank you! This really cleans up a lot.

@abey79 abey79 merged commit 02d55cb into main Jan 25, 2024
41 checks passed
@abey79 abey79 deleted the antoine/blueprint_id_instead_of_tile_id branch January 25, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants