Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatype deduplication 1: remove polars #4880

Merged
merged 11 commits into from
Jan 23, 2024
Merged

Datatype deduplication 1: remove polars #4880

merged 11 commits into from
Jan 23, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jan 22, 2024

All the grunt work left to get rid of polars.

  • Remove all helpers and APIs built specifically for polars' DataFrame.
  • Refactor tests that rely on dataframe joins to not require join semantics in the first place (re_data_store has no knowledge of those anyway).
  • The one test that does require join semantics has moved over to re_query, where join semantics belong.
  • All polars-* dep have been removed.

Don't look at the commit log as it makes no sense: i changed strategies a bunch of times on the way.



Part of the tiny datatype deduplication PR series:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@teh-cmc teh-cmc added dependencies concerning crates, pip packages etc 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md do-not-merge Do not merge this PR labels Jan 22, 2024
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY! :D

.compare_exchange(false, true, Ordering::SeqCst, Ordering::SeqCst)
.is_ok()
{
re_log::setup_native_logging();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above code would be more idiomatic using std::sync::Once.

It could also be moved into setup_native_logging

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah i've told myself I'd clean this a million times... I'll do so in a follow up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teh-cmc teh-cmc force-pushed the cmc/primcache_19_statification branch from dd80167 to 5b4e1d4 Compare January 23, 2024 16:51
Base automatically changed from cmc/primcache_19_statification to main January 23, 2024 17:01
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Jan 23, 2024
@teh-cmc teh-cmc merged commit 80d52e9 into main Jan 23, 2024
40 checks passed
@teh-cmc teh-cmc deleted the cmc/polarless branch January 23, 2024 17:24
teh-cmc added a commit that referenced this pull request Jan 24, 2024
Grunt work to switch to `re_arrow2` and all the breaking changes that
come with it.

- Fixes #4789

---

Part of the tiny datatype deduplication PR series:
- #4880
- #4883
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies concerning crates, pip packages etc exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants