-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datatype deduplication 1: remove polars #4880
Conversation
d354ce7
to
ca6a06c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YAY! :D
.compare_exchange(false, true, Ordering::SeqCst, Ordering::SeqCst) | ||
.is_ok() | ||
{ | ||
re_log::setup_native_logging(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above code would be more idiomatic using std::sync::Once
.
It could also be moved into setup_native_logging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah i've told myself I'd clean this a million times... I'll do so in a follow up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dd80167
to
5b4e1d4
Compare
ca6a06c
to
516d5cc
Compare
All the grunt work left to get rid of polars.
DataFrame
.re_data_store
has no knowledge of those anyway).re_query
, where join semantics belong.polars-*
dep have been removed.Don't look at the commit log as it makes no sense: i changed strategies a bunch of times on the way.
arrow2
and get rid ofpolars
#4789Part of the tiny datatype deduplication PR series:
re_arrow2
#4883Checklist
main
build: app.rerun.ionightly
build: app.rerun.io