Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always point to versioned manifest when building a versioned binary #4781

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Jan 10, 2024

What

The logic here is that if you check out 0.12.0 and do a source build you probably want the 0.12.0 examples, not the example from main. This is generally what folks will want if integrating a rerun-build into a third-party system, and similarly applies to conda.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jleibs jleibs marked this pull request as ready for review January 10, 2024 18:30
@jleibs jleibs added ⛴ release Related to shipping or publishing 🪳 bug Something isn't working labels Jan 10, 2024
@jleibs jleibs added this to the 0.12.1 milestone Jan 16, 2024
@jleibs jleibs merged commit 8cd526a into main Jan 16, 2024
40 of 45 checks passed
@jleibs jleibs deleted the jleibs/always_point_releases_at_release_examples branch January 16, 2024 13:02
emilk pushed a commit that referenced this pull request Jan 17, 2024
…4781)

### What
 - Resolves: #4778

The logic here is that if you check out 0.12.0 and do a source build you
probably want the 0.12.0 examples, not the example from main. This is
generally what folks will want if integrating a rerun-build into a
third-party system, and similarly applies to conda.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4781/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4781/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4781/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4781)
- [Docs
preview](https://rerun.io/preview/937bfc1a07fb179f66fa487768a0f5067c15398f/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/937bfc1a07fb179f66fa487768a0f5067c15398f/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog ⛴ release Related to shipping or publishing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conda install of 0.12.0 points at example manifest from main
2 participants