Fix entity_path_vec! and entity_path! depending on ToString being in scope.
#4766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng in scope. The macro used to work in `no_std`+`alloc` conditions, but that was broken in 0.12 by the addition of the `.to_string()` call. This change fixes it by making all items used by the macro use fully qualified, reexported paths; this way, the macro does not depend on the calling module and crate's imports at all.
emilk
approved these changes
Jan 10, 2024
kpreid
added a commit
to kpreid/all-is-cubes
that referenced
this pull request
Jan 11, 2024
Unfortunately, `entity_path!` started needing `ToString` in scope. Filed rerun-io/rerun#4766 to fix that.
emilk
pushed a commit
that referenced
this pull request
Jan 17, 2024
…ng in scope. (#4766) ### What The macros used to work in `no_std`+`alloc` conditions, but that was broken in 0.12 by the addition of the `.to_string()` call. This change fixes it by making all items used by the macro use fully qualified, reexported paths; this way, the macro does not depend on the calling module and crate's imports at all. This change would ideally be released as a 0.12.1 bugfix. ### Checklist * [X] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [X] ~~I've included a screenshot or gif (if applicable)~~ * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/4766/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/4766/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/4766/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [X] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4766) - [Docs preview](https://rerun.io/preview/8d39d674d8a6a26a3e9586553a2eab3264152240/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/8d39d674d8a6a26a3e9586553a2eab3264152240/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The macros used to work in
no_std+allocconditions, but that was broken in 0.12 by the addition of the.to_string()call. This change fixes it by making all items used by the macro use fully qualified, reexported paths; this way, the macro does not depend on the calling module and crate's imports at all.This change would ideally be released as a 0.12.1 bugfix.
Checklist
I've included a screenshot or gif (if applicable)mainbuild: app.rerun.ionightlybuild: app.rerun.io