Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to egui 0.25 and winit 0.29 #4732

Merged
merged 15 commits into from
Jan 10, 2024
Merged

Update to egui 0.25 and winit 0.29 #4732

merged 15 commits into from
Jan 10, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Jan 8, 2024 •
edited by github-actions bot
Loading

What

@Wumpf please test the re_renderer examples.

There's a bunch of new duplicated dependencies, which sucks. I've tried to ping the maintainers of the offending packages.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@emilk emilk added 📺 re_viewer affects re_viewer itself dependencies concerning crates, pip packages etc include in changelog labels Jan 8, 2024
@emilk emilk requested a review from Wumpf January 8, 2024 15:03
emilk added 9 commits January 8, 2024 16:11
@emilk
Update to egui 0.25 and winit 0.29
7769d9c
@emilk
Update arboard
4fd92e0 
    Updating crates.io index
    Updating arboard v3.2.0 -> v3.3.0
    Updating gethostname v0.2.3 -> v0.3.0
    Removing memoffset v0.6.5
    Removing nix v0.24.3
    Updating x11rb v0.10.1 -> v0.12.0
    Updating x11rb-protocol v0.10.0 -> v0.12.0
@emilk
Update rfd and ashpd
48ff3e7 
❯ cargo update -p rfd
    Updating crates.io index
    Updating rfd v0.12.0 -> v0.12.1

❯ cargo update -p ashpd
    Updating crates.io index
    Updating ashpd v0.6.2 -> v0.6.8
      Adding async-fs v2.1.0
    Removing async-global-executor v2.3.1
      Adding async-net v2.0.0
    Removing async-std v1.12.0
    Removing ctor v0.1.26
      Adding fastrand v2.0.1
    Removing gloo-timers v0.2.6
    Removing kv-log-macro v1.0.7
    Removing value-bag v1.0.0-alpha.9
@emilk
Update deny.toml
04319d8
@emilk
Make sure more specific key bindings are checked first
6624c66
@emilk
Trim deny.toml
ced36ed
@emilk
cargo update -p gpu-descriptor
ef0fb15 
    Updating crates.io index
    Removing ahash v0.7.7
      Adding allocator-api2 v0.2.16
    Updating gpu-descriptor v0.2.3 -> v0.2.4
@emilk
cargo update -p backtrace
2e9fcf8 
    Updating crates.io index
    Updating addr2line v0.19.0 -> v0.21.0
    Updating backtrace v0.3.67 -> v0.3.69
    Updating gimli v0.27.2 -> v0.28.1
    Removing miniz_oxide v0.6.2
    Updating object v0.30.3 -> v0.32.2
@emilk
cargo update -p xcursor
d5188c0 
    Updating crates.io index
    Removing minimal-lexical v0.2.1
    Removing nom v7.1.3
    Updating xcursor v0.3.4 -> v0.3.5
Wumpf
Wumpf reviewed Jan 8, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@Wumpf
Copy link
Member

Wumpf commented Jan 8, 2024

@Wumpf please test the re_renderer examples.

examples no longer animate/request new frames. E.g. check cargo run -p re_renderer_examples --bin 2d, the right side is supposed to rotate but it only refreshes when resizing

@emilk emilk marked this pull request as ready for review January 8, 2024 16:17
@Wumpf Wumpf self-requested a review January 9, 2024 09:38
Wumpf
Wumpf approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
let's briefly hold on with this until the release is done :)

@emilk emilk mentioned this pull request Jan 9, 2024
Closed
@emilk emilk merged commit 74b5ffa into main Jan 10, 2024
40 checks passed
@emilk emilk deleted the emilk/egui-0.25 branch January 10, 2024 08:09
@abey79 abey79 removed the 📺 re_viewer affects re_viewer itself label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
dependencies concerning crates, pip packages etc include in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilk @Wumpf @abey79