Change modal position to a fixed vertical distance from the top of the window #4700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the modal moving vertically when content size changes.
abey79
changed the title
emilk
added
blocked
you should be able to circumvent that by giving the Window a new id than whats already persisted |
emilk
reviewed
Jan 5, 2024
| @@ -109,10 +130,16 @@ impl Modal { | |||
|
|
|||
| let mut open = ui.input(|i| !i.key_pressed(egui::Key::Escape)); | |||
|
|
|||
| let screen_height = ui.ctx().screen_rect().height(); | |||
| let modal_vertical_margins = (75.0).at_most(screen_height * 0.1); | |||
|
|
|||
| let mut window = egui::Window::new(&self.title) | |||
There was a problem hiding this comment.
Suggested change
| let mut window = egui::Window::new(&self.title) | |
| let mut window = egui::Window::new(&self.title) | |
| .id(egui::Id::new("modal", &self.title)) // Workaround for https://github.com/emilk/egui/pull/3721 until we make a new egui release |
There was a problem hiding this comment.
Works (well—to the extent that it invalidates any existing cache).
There was a problem hiding this comment.
And the bug was only when changing pivot, right ?
There was a problem hiding this comment.
Yes, that's correct. So we should be good.
emilk
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This avoids the modal moving vertically when content size changes.
NOTE: this PR would trigger the bug fixed in emilk/egui#3721, so it needs an egui release before being released. This is avoided by salting the modals' ID such as to in invalidate existing caches.
modal_position.mp4
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io