Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the new container blueprints the default behavior #4642

Merged
merged 5 commits into from
Jan 3, 2024
Merged

Make the new container blueprints the default behavior #4642

merged 5 commits into from
Jan 3, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Jan 2, 2024 •
edited by github-actions bot
Loading

What

  • Instead of opting in, users can now opt out using the app option: legacy_container_blueprint
  • Fix some egui-tiles warnings (these were present even with the legacy behavior).

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jleibs jleibs added the 🟦 blueprint The data that defines our UI label Jan 2, 2024
@jleibs jleibs changed the title Make it so that the new container blueprints are default Make the new container blueprints the default behavior Jan 2, 2024
@jleibs jleibs marked this pull request as ready for review January 2, 2024 18:16
emilk
emilk reviewed Jan 3, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
emilk
emilk requested changes Jan 3, 2024
View reviewed changes
Copy link
Member

@emilk emilk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get rerun-io/egui_tiles#41 merged first so we can patch with a commit to egui_tiles trunk instead

@jleibs jleibs requested a review from emilk January 3, 2024 14:54
@emilk emilk merged commit da88fdd into main Jan 3, 2024
40 checks passed
@emilk emilk deleted the jleibs/enable_container_blueprints branch January 3, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
🟦 blueprint The data that defines our UI include in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jleibs @emilk