Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show entity path parts (entity "folder" names) unescaped in UI #4603

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Show entity path parts (entity "folder" names) unescaped in UI #4603

merged 2 commits into from
Dec 21, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Dec 20, 2023 •
edited by github-actions bot
Loading

What

Remove Display implementation for EntityPathPart, forcing users to explicitly chose between three members:

  • escaped_string
  • unescaped_str
  • ui_string

ui_string is only there so we can change this again in the future.

NOTE: this PR still escapes full entity paths everywhere

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@emilk
Show entity path parts (entity "folder" names) unescaped
bd1b1e0 
Remove `Display` implementation for `EntityPathPart`,
forcing users to explicitly chose between three memberes:

* `escaped_string`
* `unescaped_str`
* `ui_string`

`ui_string` is only there so we can change this again in the future.

NOTE: this PR still escapes full entity paths everywhere
@emilk emilk added ui concerns graphical user interface include in changelog labels Dec 20, 2023
abey79
abey79 approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to remove Display 👍🏻

crates/re_log_types/src/path/entity_path_part.rs Outdated Show resolved Hide resolved
@emilk @abey79
typo
c9e67e7 
Co-authored-by: Antoine Beyeler <[email protected]>
@emilk emilk merged commit b51793b into main Dec 21, 2023
40 checks passed
@emilk emilk deleted the emilk/unescaped-entity-names branch December 21, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abey79 abey79 abey79 approved these changes

Assignees
No one assigned
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @abey79