-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3D->2D & 2D->3D selection visualizations stick now around on selection #4587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
enhancement
New feature or request
📺 re_viewer
affects re_viewer itself
include in changelog
labels
Dec 19, 2023
Yeah that's expected so far. There's some curious asymmetries in the code about how this works out for hover & select. But I reckon it wouldn't be hard to set right 🤔:
|
Let's do it. It would be pretty neat for multi point in the 3d viewport |
… and tracked for selections themselves
… selection history
Wumpf
force-pushed
the
andreas/sticky-hover-line
branch
from
December 20, 2023 11:34
ecdadae
to
c196717
Compare
teh-cmc
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Makes the 2D->3D and 3D->2D sticky upon selection!
Going the extra mile to make selection history be aware of this added a bit more stuff, but the code is better off overall I think :)
sticky.projections.mp4
Update! Now also works fine with multielection!
We now associate each item selection with an optional space context. Right now you can't space context without items, but this is not a structural limitation.
Toggle (ctrl+cmd select action) behavior has a few new special rules now: If you change the space view context on an already selected object its context is updated. If you add a new object, we add it to the list with the context.
Overall this paves also the way to displaying the context together with the selected item in a more sane way. Should be easier to reason with in general I believe.
Screen.Recording.2023-12-20.at.13.10.22.mov
Checklist
main
build: app.rerun.ionightly
build: app.rerun.io