Speed up query usage in heuristics by splitting DataQuery into separate query and update_properties passes #4563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
added
📉 performance
Wumpf
force-pushed
the
jleibs/skip_empty_queries
branch
from
3f0cd4a
to
f3e06ae
Compare
Wumpf
force-pushed
the
jleibs/optmize_queries
branch
from
80d3841
to
5a0d21e
Compare
Wumpf
requested changes
Dec 18, 2023
| @@ -117,7 +117,7 @@ pub struct SelectionState { | |||
| impl SelectionState { | |||
| /// Called at the start of each frame | |||
| pub fn on_frame_start(&mut self, item_retain_condition: impl Fn(&Item) -> bool) { | |||
| re_tracing::profile_function!(); | |||
| re_tracing::profile_scope!("SelectionState::on_frame_start"); | |||
There was a problem hiding this comment.
isn't that esactly what the profile_function macro prints, no?
There was a problem hiding this comment.
Not quite -- it seems like puffin doesn't track the struct name and so I was seeing two calls to on_frame_start coming from different call-sites resulting in some unexpected aggregation.
There was a problem hiding this comment.
Is that with latest puffin? afaik what scopes are merged when improved a bit, but might have been mostly about traits
jleibs
force-pushed
the
jleibs/optmize_queries
branch
2 times, most recently
from
0329e12
to
18571c5
Compare
jleibs
force-pushed
the
jleibs/optmize_queries
branch
from
18571c5
to
b822d31
Compare
jleibs
changed the title
Wumpf
approved these changes
Dec 21, 2023
| // to do this or else the auto_properties aren't right since they get populated | ||
| // in on_frame_start, but on_frame_start also needs the queries. | ||
| let updated_query_results = { | ||
| { | ||
| re_tracing::profile_scope!("updated_query_results"); |
There was a problem hiding this comment.
nit: more like "update_overrides" now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
After adding some scopes, found some more wins on query processing. This is a mixture of some optimized short-circuit early-outs, and doing the PropertyOverride logic on a second-pass in order to avoid any overhead related to creating the EntityProperty structures and override entity-paths.
This has the added benefit of also removing the second query and replacing it with a much easier-to-follow override processor.
Before:
After:
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io