Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve spurious blueprint panel group collapsing #4548

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Resolve spurious blueprint panel group collapsing #4548

merged 1 commit into from
Dec 15, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Dec 14, 2023 •
edited
Loading

What

Needed to make the id deterministic since the value of DataResultHandle was basically just a function of how many children the data-result had.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jleibs jleibs marked this pull request as ready for review December 14, 2023 23:47
@jleibs jleibs added ui concerns graphical user interface 🦟 regression A thing that used to work in an earlier release exclude from changelog PRs with this won't show up in CHANGELOG.md include in changelog and removed exclude from changelog PRs with this won't show up in CHANGELOG.md labels Dec 14, 2023
@jleibs jleibs changed the title Use the entity_path when determining id for collapsible state of a data-result Resolve spurious blueprint panel group collapsing Dec 14, 2023
@jleibs jleibs merged commit 5254c42 into main Dec 15, 2023
44 of 49 checks passed
@jleibs jleibs deleted the jleibs/stable_blueprint_tree_ids branch December 15, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh-cmc teh-cmc teh-cmc approved these changes

Assignees
No one assigned
Labels
include in changelog 🦟 regression A thing that used to work in an earlier release ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing entity from blueprint panel sometimes collapses parent
2 participants
@jleibs @teh-cmc