Keep global registry of all visualizers & context systems instead of isolating per space view class #4540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to store additional state with each registry entry: This will be used to register a `VisualizerEntitySubscriber` and store a handle to it for every visualizer Note that this pr sneakily starts the renaming of `ViewPart(System)` to just `Visualizer`
Wumpf
added
🚜 refactor
Size changes
|
|
Putting a massive renaming change in the same commit as everything else was not very nice of you @Wumpf 🥲 EDIT: Ha nevermind after having a closer look it's more tricky than that 😶 |
teh-cmc
approved these changes
Dec 15, 2023
| struct SpaceViewClassRegistryEntry { | ||
| class: Box<dyn DynSpaceViewClass>, | ||
| systems: SpaceViewSystemRegistry, | ||
| context_systems: HashSet<ViewSystemIdentifier>, |
There was a problem hiding this comment.
then I guess they are... contextualizers? 👀
There was a problem hiding this comment.
hehe :D. Was actually wondering if it's still VisualizerSystem in this context, to not make system stick out too much
ah yeah it's not the massive change that is going to happen. But still kinda guilty as I started chipping away on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This will allow us to store additional state with each registry entry: This will be used to register a
VisualizerEntitySubscriberand store a handle to it for every visualizer.All the "interesting" changes are in
crates/re_viewer_context/src/space_view/space_view_class_registry.rs, everything else is just ripples.Note that this pr sneakily starts the renaming of
ViewPart(System)to justVisualizerChecklist