Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of sync_blueprint_changes #4524

Merged
merged 27 commits into from
Dec 15, 2023
Merged

Get rid of sync_blueprint_changes #4524

merged 27 commits into from
Dec 15, 2023

Commits on Dec 14, 2023

  1. Configuration menu
    Copy the full SHA
    bbdfa2e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7632b76 View commit details
    Browse the repository at this point in the history
  3. Fix multi-space-view additions

    jleibs committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    7f55c5c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0be8bea View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    86f5c27 View commit details
    Browse the repository at this point in the history
  6. cpp/py codegen

    jleibs committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    f67ee39 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0864773 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    54bc722 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b39fa0c View commit details
    Browse the repository at this point in the history
  10. Has edits logic can go away

    jleibs committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    28d1a8f View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    6c757fa View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    8293a56 View commit details
    Browse the repository at this point in the history
  13. Also clear queries

    jleibs committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    e8867de View commit details
    Browse the repository at this point in the history
  14. Rename

    jleibs committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    8f852f0 View commit details
    Browse the repository at this point in the history
  15. no need for a reset TreeAction

    jleibs committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    6190ffe View commit details
    Browse the repository at this point in the history
  16. no-op sets are no-op

    jleibs committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    2b8291e View commit details
    Browse the repository at this point in the history
  17. Inline the set_ operations

    jleibs committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    5c9da52 View commit details
    Browse the repository at this point in the history
  18. doc-link

    jleibs committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    0987ae2 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. When duplicating a SpaceViewBlueprint, also duplicate its Query (#4549)

    ### What
    - Resolves: #4456
    
    The crux of the problem is cloning the SpaceView created a new SpaceView
    with the same DataQuery reference (which is where the property overrides
    are stored).
    
    Since cloning the internal IDs of a SpaceView or DataQuery can have
    unintended consequences, I removed Clone from these types and replaced
    it with a `duplicate` method with clearer semantics.
    
    Also had to clean up the heuristic path to get rid of the one otherwise
    unnecessary clone.
    
    ### Checklist
    * [x] I have read and agree to [Contributor
    Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
    the [Code of
    Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
    * [x] I've included a screenshot or gif (if applicable)
    * [x] I have tested the web demo (if applicable):
    * Using newly built examples:
    [app.rerun.io](https://app.rerun.io/pr/4549/index.html)
    * Using examples from latest `main` build:
    [app.rerun.io](https://app.rerun.io/pr/4549/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
    * Using full set of examples from `nightly` build:
    [app.rerun.io](https://app.rerun.io/pr/4549/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
    * [x] The PR title and labels are set such as to maximize their
    usefulness for the next release's CHANGELOG
    
    - [PR Build Summary](https://build.rerun.io/pr/4549)
    - [Docs
    preview](https://rerun.io/preview/f128e543a4e06edee55f1a089b1b6a9837ca43b0/docs)
    <!--DOCS-PREVIEW-->
    - [Examples
    preview](https://rerun.io/preview/f128e543a4e06edee55f1a089b1b6a9837ca43b0/examples)
    <!--EXAMPLES-PREVIEW-->
    - [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
    - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
    jleibs authored Dec 15, 2023
    Configuration menu
    Copy the full SHA
    2b2b0db View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    430cf7f View commit details
    Browse the repository at this point in the history
  3. PR cleanup

    jleibs committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    4021e95 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5764be4 View commit details
    Browse the repository at this point in the history
  5. typo

    jleibs committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    774a763 View commit details
    Browse the repository at this point in the history
  6. More comment cleanup

    jleibs committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    e05798a View commit details
    Browse the repository at this point in the history
  7. proper doc links

    jleibs committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    2d695ef View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b5a1371 View commit details
    Browse the repository at this point in the history
  9. lint

    jleibs committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    db70230 View commit details
    Browse the repository at this point in the history