-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of sync_blueprint_changes
#4524
Merged
Merged
Commits on Dec 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for bbdfa2e - Browse repository at this point
Copy the full SHA bbdfa2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7632b76 - Browse repository at this point
Copy the full SHA 7632b76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f55c5c - Browse repository at this point
Copy the full SHA 7f55c5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0be8bea - Browse repository at this point
Copy the full SHA 0be8beaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 86f5c27 - Browse repository at this point
Copy the full SHA 86f5c27View commit details -
Configuration menu - View commit details
-
Copy full SHA for f67ee39 - Browse repository at this point
Copy the full SHA f67ee39View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0864773 - Browse repository at this point
Copy the full SHA 0864773View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54bc722 - Browse repository at this point
Copy the full SHA 54bc722View commit details -
Configuration menu - View commit details
-
Copy full SHA for b39fa0c - Browse repository at this point
Copy the full SHA b39fa0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 28d1a8f - Browse repository at this point
Copy the full SHA 28d1a8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c757fa - Browse repository at this point
Copy the full SHA 6c757faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8293a56 - Browse repository at this point
Copy the full SHA 8293a56View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8867de - Browse repository at this point
Copy the full SHA e8867deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f852f0 - Browse repository at this point
Copy the full SHA 8f852f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6190ffe - Browse repository at this point
Copy the full SHA 6190ffeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b8291e - Browse repository at this point
Copy the full SHA 2b8291eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c9da52 - Browse repository at this point
Copy the full SHA 5c9da52View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0987ae2 - Browse repository at this point
Copy the full SHA 0987ae2View commit details
Commits on Dec 15, 2023
-
When duplicating a SpaceViewBlueprint, also duplicate its Query (#4549)
### What - Resolves: #4456 The crux of the problem is cloning the SpaceView created a new SpaceView with the same DataQuery reference (which is where the property overrides are stored). Since cloning the internal IDs of a SpaceView or DataQuery can have unintended consequences, I removed Clone from these types and replaced it with a `duplicate` method with clearer semantics. Also had to clean up the heuristic path to get rid of the one otherwise unnecessary clone. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/4549/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/4549/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/4549/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4549) - [Docs preview](https://rerun.io/preview/f128e543a4e06edee55f1a089b1b6a9837ca43b0/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/f128e543a4e06edee55f1a089b1b6a9837ca43b0/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Configuration menu - View commit details
-
Copy full SHA for 2b2b0db - Browse repository at this point
Copy the full SHA 2b2b0dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 430cf7f - Browse repository at this point
Copy the full SHA 430cf7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4021e95 - Browse repository at this point
Copy the full SHA 4021e95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5764be4 - Browse repository at this point
Copy the full SHA 5764be4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 774a763 - Browse repository at this point
Copy the full SHA 774a763View commit details -
Configuration menu - View commit details
-
Copy full SHA for e05798a - Browse repository at this point
Copy the full SHA e05798aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d695ef - Browse repository at this point
Copy the full SHA 2d695efView commit details -
Configuration menu - View commit details
-
Copy full SHA for b5a1371 - Browse repository at this point
Copy the full SHA b5a1371View commit details -
Configuration menu - View commit details
-
Copy full SHA for db70230 - Browse repository at this point
Copy the full SHA db70230View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.