Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Blueprint types to be full Archetype/Components within a scoped namespace #4477

Merged
merged 14 commits into from
Dec 12, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Dec 11, 2023

What

Blueprint code will benefit from being able to leverage the same Archetype / Component patterns as our other datatypes.

Rather than treating Blueprint as an alternative ObjectKind this now uses a blueprint scope for the given blueprint types. This had some obnoxious fan-out to clean up all of the C++ header / include / namespace / python import stuff.

Probably best reviewed commit by commit.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
    • Full build: app.rerun.io
    • Partial build: app.rerun.io - Useful for quick testing when changes do not affect examples in any way
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jleibs jleibs added 🟦 blueprint The data that defines our UI codegen/idl labels Dec 11, 2023
@jleibs jleibs changed the title Refactor blueprint codegen to use a scoped path Allow Blueprint types to be full Archetype/Components within a scoped namespace Dec 11, 2023
@jleibs jleibs marked this pull request as ready for review December 11, 2023 20:31
@jleibs jleibs added the exclude from changelog PRs with this won't show up in CHANGELOG.md label Dec 11, 2023
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One oddity in the C++ output but other than that I think this looks as expected. 🥵

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ We're in rerun/blueprint/blueprint, something went wrong... is this some orphaned thing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, yes, that was one of the things that got fixed later in the stack but I failed to commit the removal. Thanks for catching.

@jleibs jleibs merged commit ab2b047 into main Dec 12, 2023
43 checks passed
@jleibs jleibs deleted the jleibs/blueprint_scoping branch December 12, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants