-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move re_renderer examples to its own crate in order to make workspace level examples less confusing #4472
Conversation
This way we don't show renderer examples like "the examples" and are able to fix dependency related issues when trying to build them on web
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh man I completely forgot about these; the memories 🥲
Anyway, looks nice! Here's a crazy idea though: can we move re_renderer_examples
under re_renderer
?
As in, it would still be an independent crate, with a cargo name of re_renderer_examples
but a repo/filesystem name of re_renderer/examples
?
@@ -117,6 +117,7 @@ Update instructions: | |||
| rerun_c | Rerun C SDK | | |||
| rerun_py | Rerun Python SDK | | |||
| re_sdk | Rerun logging SDK | | |||
<!-- | re_renderer_examples | Examples for re_renderer | --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, what's this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
our ci wants now all crates to be listed here, but I figured that's a weird one to list. So I pretend list it!
👍 I'll try that! Not sure if cargo gets confused by this |
tried and Cargo doesn't like it at all. We figured it's time to directorify crates, not happening in this PR though. |
7550d12
to
dc1e339
Compare
What
This way we don't show renderer examples like "the examples". Also, due to some dependency issues with the optional re_renderer arrow dependency (details somewhat unclear..), we were previously no longer able to run examples on the web. This works nicely now again:
depicted:
cargo run -p re_renderer_examples --bin multiview
(native)cargo run-wasm -p re_renderer_examples --bin multiview --features "webgl"
(webgl, using firefox here)cargo run-wasm -p re_renderer_examples --bin multiview
(webgpu, using chrome here)Checklist