Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move re_renderer examples to its own crate in order to make workspace level examples less confusing #4472

Merged
merged 8 commits into from
Dec 12, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Dec 11, 2023

What

This way we don't show renderer examples like "the examples". Also, due to some dependency issues with the optional re_renderer arrow dependency (details somewhat unclear..), we were previously no longer able to run examples on the web. This works nicely now again:

image

depicted:

  • cargo run -p re_renderer_examples --bin multiview (native)
  • cargo run-wasm -p re_renderer_examples --bin multiview --features "webgl" (webgl, using firefox here)
  • cargo run-wasm -p re_renderer_examples --bin multiview (webgpu, using chrome here)

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
    • Full build: app.rerun.io
    • Partial build: app.rerun.io - Useful for quick testing when changes do not affect examples in any way
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

This way we don't show renderer examples like "the examples" and are able to fix dependency related issues when trying to build them on web
@Wumpf Wumpf added 🔺 re_renderer affects re_renderer itself 🚜 refactor Change the code, not the functionality include in changelog labels Dec 11, 2023
@teh-cmc teh-cmc self-requested a review December 12, 2023 07:28
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man I completely forgot about these; the memories 🥲

Anyway, looks nice! Here's a crazy idea though: can we move re_renderer_examples under re_renderer?
As in, it would still be an independent crate, with a cargo name of re_renderer_examples but a repo/filesystem name of re_renderer/examples?

@@ -117,6 +117,7 @@ Update instructions:
| rerun_c | Rerun C SDK |
| rerun_py | Rerun Python SDK |
| re_sdk | Rerun logging SDK |
<!-- | re_renderer_examples | Examples for re_renderer | -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, what's this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our ci wants now all crates to be listed here, but I figured that's a weird one to list. So I pretend list it!

@Wumpf
Copy link
Member Author

Wumpf commented Dec 12, 2023

As in, it would still be an independent crate, with a cargo name of re_renderer_examples but a repo/filesystem name of re_renderer/examples?

👍 I'll try that! Not sure if cargo gets confused by this

@Wumpf
Copy link
Member Author

Wumpf commented Dec 12, 2023

tried and Cargo doesn't like it at all. We figured it's time to directorify crates, not happening in this PR though.

@Wumpf Wumpf force-pushed the andreas/re_renderer/separate-examples branch from 7550d12 to dc1e339 Compare December 12, 2023 09:15
@Wumpf Wumpf merged commit 11ebbef into main Dec 12, 2023
40 checks passed
@Wumpf Wumpf deleted the andreas/re_renderer/separate-examples branch December 12, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🔺 re_renderer affects re_renderer itself 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants