Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the possibility to add empty space views of all registered types #4467

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Add the possibility to add empty space views of all registered types #4467

merged 2 commits into from
Dec 11, 2023

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Dec 11, 2023 •
edited
Loading

What

What the title says ☝🏻

A list of all space view type is added to the "Add space view" button. They all default to / as space origin.

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
    • Full build: app.rerun.io
    • Partial build: app.rerun.io - Useful for quick testing when changes do not affect examples in any way
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@abey79 abey79 added ui concerns graphical user interface include in changelog labels Dec 11, 2023
@Wumpf Wumpf self-requested a review December 11, 2023 14:41
Wumpf
Wumpf approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Definitely an improvement!

@Wumpf Wumpf merged commit afd0203 into main Dec 11, 2023
40 of 41 checks passed
@Wumpf Wumpf deleted the antoine/create-empty-space-views branch December 11, 2023 14:42
@Wumpf Wumpf added the 📺 re_viewer affects re_viewer itself label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
include in changelog 📺 re_viewer affects re_viewer itself ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abey79 @Wumpf