-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallize Space View system evaluation #4460
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssary Sync/Send restrictions
…to new egui_tiles ticket
Wumpf
added
📺 re_viewer
affects re_viewer itself
📉 performance
Optimization, memory use, etc
include in changelog
labels
Dec 7, 2023
emilk
approved these changes
Dec 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wonderful ⭐⭐⭐
I pushed a few commits to improve the puffin profiler output slightly, PTAL
crates/re_viewer_context/src/space_view/system_execution_output.rs
Outdated
Show resolved
Hide resolved
crates/re_viewer_context/src/space_view/system_execution_output.rs
Outdated
Show resolved
Hide resolved
thanks for those commits, much nicer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
include in changelog
📉 performance
Optimization, memory use, etc
📺 re_viewer
affects re_viewer itself
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Two levels of parallism actually:
This gives us major speedups whenever:
As such this is a very fundamental & widely applicable parallelization!
(busy rayon worker threads!)(a rather silly "points with arrows" scene duplicated a bunch of times. Note that we still don't have any caching, so all these space views might as well be animated individually!)
Related things that are not parallel yet:
Checklist
End of a series on refactors leading to this parallization: