Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove builds and usage of demo.rerun.io #4418

Merged
merged 15 commits into from
Dec 4, 2023
Merged

Remove builds and usage of demo.rerun.io #4418

merged 15 commits into from
Dec 4, 2023

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented Dec 1, 2023

What

Part of #4277

There's still usage of the build_demo_app script in the screenshot comparison tool, and I wasn't feeling quite brave enough to also rip it out from there in this PR.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
    • Full build: app.rerun.io
    • Partial build: app.rerun.io - Useful for quick testing when changes do not affect examples in any way
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jprochazk jprochazk added 🕸️ web regarding running the viewer in a browser include in changelog labels Dec 1, 2023
@jprochazk
Copy link
Member Author

jprochazk commented Dec 1, 2023

The build_demo_app.py script is left untouched, because it was also used by the screenshot comparison tool. Instead of patching it and trying to make it work, I rewrote it in Rust. I'm more convinced than ever that we should actively push to rewrite all of our scripts as soon as possible, just because of the staggering difference in DX between writing this kind of code in Rust vs Python

@jprochazk jprochazk marked this pull request as draft December 1, 2023 12:32
@jprochazk jprochazk marked this pull request as ready for review December 1, 2023 14:22
@emilk
Copy link
Member

emilk commented Dec 4, 2023

Please write an issue for finishing up the port of build_demo_app.py, and then work on that next. Porting to Rust is good, but duplicating scripts is not :)

crates/re_build_examples/Cargo.toml Show resolved Hide resolved
crates/re_build_examples/Cargo.toml Outdated Show resolved Hide resolved
crates/re_build_examples/Cargo.toml Outdated Show resolved Hide resolved
crates/re_build_examples_manifest/Cargo.toml Show resolved Hide resolved
@jprochazk
Copy link
Member Author

@jprochazk jprochazk merged commit d74d3d3 into main Dec 4, 2023
40 checks passed
@jprochazk jprochazk deleted the jan/nuke-demo branch December 4, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants