Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datastore: don't eagerly sort in bucket split rountine on ingestion path #4417

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Dec 1, 2023

This should fix #4415, although without knowing how exactly the user ended up in that situation it's hard to say for certain.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
    • Full build: app.rerun.io
    • Partial build: app.rerun.io - Useful for quick testing when changes do not affect examples in any way
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@teh-cmc teh-cmc added 🪳 bug Something isn't working ⛃ re_datastore affects the datastore itself 🚀 performance Optimization, memory use, etc include in changelog labels Dec 1, 2023
@teh-cmc teh-cmc merged commit ec77988 into main Dec 1, 2023
44 of 47 checks passed
@teh-cmc teh-cmc deleted the cmc/split_early_sort branch December 1, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog 🚀 performance Optimization, memory use, etc ⛃ re_datastore affects the datastore itself
Projects
None yet
2 participants