Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log wgpu adapter on web #4414

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Log wgpu adapter on web #4414

merged 3 commits into from
Dec 1, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Dec 1, 2023

Best reviewed commit-by-commit

What

We previously only logged the wgpu adapter info on native builds. This means we never logged wether or not the web viewer was using WebGL or WebGPU, for instance. With this PR, I now see this in my Arc browser log:

wgpu adapter backend: Gl, device_type: IntegratedGpu, name: "ANGLE (Apple, Apple M1 Pro, OpenGL 4.1)"

I also cleaned up the logging, omitting empty strings.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested app.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@emilk emilk added 🕸️ web regarding running the viewer in a browser 🔺 re_renderer affects re_renderer itself labels Dec 1, 2023
@emilk emilk changed the title Improve wgpu adapter logging Log wgpu adapter on web Dec 1, 2023
@emilk
Copy link
Member Author

emilk commented Dec 1, 2023

This PR improved the logging in re_renderer, but I also added more logging to the next release of egui-wgpu:

@emilk emilk merged commit 2f8b31f into main Dec 1, 2023
40 of 44 checks passed
@emilk emilk deleted the emilk/improve-wgpu-logging branch December 1, 2023 16:02
@Wumpf
Copy link
Member

Wumpf commented Dec 1, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🔺 re_renderer affects re_renderer itself 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants