Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset accumulated bounding box when resetting camera #4369

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Reset accumulated bounding box when resetting camera #4369

merged 1 commit into from
Nov 28, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Nov 28, 2023 •
edited
Loading

What

Initial testing of this feels like a much improved user experience.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested app.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jleibs jleibs added ui concerns graphical user interface include in changelog labels Nov 28, 2023
@jleibs jleibs marked this pull request as ready for review November 28, 2023 15:49
Wumpf
Wumpf approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes a lot of sense! there might be corner cases where this is not desired but more often than not this is great

@Wumpf Wumpf merged commit 8f14f33 into main Nov 28, 2023
40 of 44 checks passed
@Wumpf Wumpf deleted the jleibs/reset_bounding_box branch November 28, 2023 16:50
teh-cmc pushed a commit that referenced this pull request Nov 30, 2023
@jleibs @teh-cmc
Reset accumulated bounding box when resetting camera (#4369)
955f9e1 
### What
- Resolves: #3750

Initial testing of this feels like a much improved user experience.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4369) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4369)
- [Docs
preview](https://rerun.io/preview/fc6d5426727628223150d4675d4d6c4f6bc59f27/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/fc6d5426727628223150d4675d4d6c4f6bc59f27/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need a way to reset the accumualted bounding box without resetting the scene
2 participants
@jleibs @Wumpf