Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++: Allow creating Image/Tensor/DepthImage/SegmentationImage directly from shape & pointer #4345

Merged
merged 5 commits into from
Nov 27, 2023
Merged

C++: Allow creating Image/Tensor/DepthImage/SegmentationImage directly from shape & pointer #4345

merged 5 commits into from
Nov 27, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Nov 27, 2023 •
edited by github-actions bot
Loading

What

Also a bunch of doc polish in related areas on the way.

Collection now has an empty method.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested app.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@Wumpf Wumpf added enhancement New feature or request 🌊 C++ API C/C++ API specific include in changelog labels Nov 27, 2023
jleibs
jleibs approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Only nit is it would be nice having an example somewhere (other than the tests) showing the pointer-based constructor mechanism.

@Wumpf
Copy link
Member Author

Wumpf commented Nov 27, 2023

We decided to let the opencv one do that instead of writing an adapter there. But I agree it would be nice to have this in the regular examples as well 🤔

@Wumpf Wumpf merged commit 69fdded into main Nov 27, 2023
45 checks passed
@Wumpf Wumpf deleted the andreas/image-archetypes-from-pointers branch November 27, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleibs jleibs jleibs approved these changes

Assignees
No one assigned
Labels
🌊 C++ API C/C++ API specific enhancement New feature or request include in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C++: Construct Image from pointer
2 participants
@Wumpf @jleibs