Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate per-PR web apps #4341

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Generate per-PR web apps #4341

merged 4 commits into from
Nov 27, 2023

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented Nov 27, 2023 •
edited
Loading

What

Closes #3953

  • Upload web app to gs://rerun-web-viewer/pr/$PR_NUMBER on every PR
  • Updated PR template to point to app.rerun.io/pr/$PR_NUMBER instead of demo.rerun.io
  • Updated GCS config to support /pr paths

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested app.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jprochazk jprochazk added 🕸️ web regarding running the viewer in a browser 🧑‍💻 dev experience developer experience (excluding CI) include in changelog labels Nov 27, 2023
@jprochazk
Copy link
Member Author

yolo-merging this one

@jprochazk jprochazk merged commit e6e2a90 into main Nov 27, 2023
41 checks passed
@jprochazk jprochazk deleted the jan/web-app-per-pr branch November 27, 2023 11:29
emilk
emilk reviewed Nov 27, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk left review comments

Assignees
No one assigned
Labels
🧑‍💻 dev experience developer experience (excluding CI) include in changelog 🕸️ web regarding running the viewer in a browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate per-pr web apps
2 participants
@jprochazk @emilk