Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export TensorBuffer & TensorDimension to rerun namespace #4331

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Nov 24, 2023

What

What it says on the tin. Makes user code/example a little bit nicer

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it in Python and Rust as well then, for consistency. It would be nice to just generate this list of exported things btw, but let's not go too crazy.


Makes user code/example a little bit nicer

Was there anything in the repo that became nicer?

@Wumpf
Copy link
Member Author

Wumpf commented Nov 27, 2023

Was there anything in the repo that became nicer?

Forgot to link: This is about the todo notes that were added in

@Wumpf
Copy link
Member Author

Wumpf commented Nov 27, 2023

Let's do it in Python and Rust as well then, for consistency.

It is super inconsistent right now which types we export where 🤔

@Wumpf
Copy link
Member Author

Wumpf commented Nov 27, 2023

rust and cpp are easy to make the same. leaving python out of this

@Wumpf Wumpf merged commit bf4b187 into main Nov 27, 2023
42 checks passed
@Wumpf Wumpf deleted the andreas/cpp/more-rerun-symbols branch November 27, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants