-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the Selection Panel with better title, context, and Space View key properties #4324
Conversation
From a first test, I think it's a pretty straight forward improvement over what we have now. I guess the only thing that is a slight negative is that we no longer write out what the type of the thing you've selected is. Since this info exists on hover and we intend to indicate the type also through a new set of icons in the future I don't think that should be a blocker. I would just ship this as-is. Good stuff! |
@nikolausWest I don't disagree. As a matter of fact, my "design" included explicit type: We shortly discussed that with @martenbjork who preferred to not overload this title bar. We can certainly revisit this and iterate. |
why not? |
I was seeing this as a first step towards a bigger story, but yeah if we like it we can roll it in 0.11—no technical reason not to. We probably shouldn't delay 0.11 for this though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the // NOLINT
is a hint that we're doing something wrong, but otherwise LGTM
### What This PR changes the way inner margins and `ScrollAreas` are nested to avoid some visual issues. - Fixes #3165 - Fixes full span display bug: #4324 (comment) ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4340) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4340) - [Docs preview](https://rerun.io/preview/71996e8cabf9dc864f4d7240779b3271472876c3/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/71996e8cabf9dc864f4d7240779b3271472876c3/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
What
Do not merge until after 0.11.This PR reworks the Selection Panel to improve the title ("What is selected?"), the context ("Where is the selected thing to be found?"), and the key properties of Space Views (name, origin, type). This is a first step towards the WIP designs by @martenbjork related to blueprints.
Changes:
Item
kinds. Previously, stuff was displayed all over the place.Note: the end-game for context is bread-crumbs like these, but that's for another day as we're don't yet have an easy way to walk up the hierarchy:
Screenshots
Space View:
Group:
Entity in Space View:
Entity in Streams:
Component:
Checklist