Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inaccessible entities being incorrectly added to space view #4226

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Fix inaccessible entities being incorrectly added to space view #4226

merged 1 commit into from
Nov 14, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Nov 14, 2023 •
edited
Loading

What

Although is_reachable_by_transform correctly accounts for disconnected spaces, visit_descendants_with_reachable_transform was never modified to account for disconnected spaces correctly. The inconsistency leads to creating a space with unreachable content in it.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jleibs jleibs marked this pull request as ready for review November 14, 2023 13:57
@Wumpf Wumpf self-requested a review November 14, 2023 14:13
@jleibs jleibs added 🪳 bug Something isn't working include in changelog labels Nov 14, 2023
@jleibs jleibs changed the title Skip disconnected spaces in visit_descendants_with_reachable_transform Fix inaccessible entities from being incorrectly added to store view Nov 14, 2023
@jleibs jleibs changed the title Fix inaccessible entities from being incorrectly added to store view Fix inaccessible entities being incorrectly added to store view Nov 14, 2023
@jleibs jleibs changed the title Fix inaccessible entities being incorrectly added to store view Fix inaccessible entities being incorrectly added to space view Nov 14, 2023
@jleibs jleibs merged commit 6a96d0d into main Nov 14, 2023
39 of 45 checks passed
@jleibs jleibs deleted the jleibs/dont_visit_disconnected branch November 14, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working include in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken space view added by heuristics
2 participants
@jleibs @Wumpf