[C++] Rename rerun::ComponentBatch to rerun::Collection (and related constructs)
#4225
Conversation
Wumpf
added
🚜 refactor
Wumpf
force-pushed
the
andreas/cpp/rerun-collection
branch
from
734f5dc to
1c08991
Compare
| @@ -1,12 +1,9 @@ | |||
| #include "../half.hpp" | |||
| #include "bar_chart.hpp" | |||
|
|
|||
| // #define EDIT_EXTENSION | |||
| namespace rerun::archetypes { | |||
There was a problem hiding this comment.
can this be added to the clang-format file?
There was a problem hiding this comment.
Only found https://clang.llvm.org/docs/ClangFormatStyleOptions.html#compactnamespaces which isn't quite the same
But as you pointed out elsewhere there's also the option to not indent after namespace, we should try that (in a separate pr)
https://clang.llvm.org/docs/ClangFormatStyleOptions.html#namespaceindentation
| } | ||
|
|
||
| // We want to change the dimension names if they are not specified. | ||
| // But rerun collections are strictly immutable, so create a new one if necessary. |
There was a problem hiding this comment.
Are we sure using Collection for TensorDimension makes sense? When will it avoid allocations and memcpys, realistically?
There was a problem hiding this comment.
it's less about avoiding copies & allocs but more about being able to use the adapters for this type as well
|
oooops, that was the wrong source branch 😳 😳. The plan was to have a PR only for up to 3de46c8 |
…ted constructs) (#4236) ### What Not much else has changed yet except some doc massaging. First step towards solving * #3794 `rerun::Collection` will evolve from here on and be the corner piece of our zero copy & component adaptability strategy (just like ComponentBatch is already!) _This was originally opened on the wrong branch by accident:_ * #4225 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4225) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4225) - [Docs preview](https://rerun.io/preview/3de46c8a5d294eb5ad68e5beb35a64d0610e992a/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/3de46c8a5d294eb5ad68e5beb35a64d0610e992a/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
What
Not much else has changed yet except some doc massaging. First step towards solving
rerun::Collectionwill evolve from here on and be the corner piece of our zero copy & component adaptability strategy (just like ComponentBatch is already!)Checklist