Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge all doc deploy jobs into a single one to avoid race conditions #4216

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Nov 13, 2023

What

.. at least we think this might help with things!

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@Wumpf Wumpf added 🪳 bug Something isn't working 🧑‍💻 dev experience developer experience (excluding CI) ⛴ release Related to shipping or publishing exclude from changelog PRs with this won't show up in CHANGELOG.md labels Nov 13, 2023
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems much less likely to have problematic race conditions.

@Wumpf Wumpf merged commit aea4ecc into main Nov 13, 2023
65 of 90 checks passed
@Wumpf Wumpf deleted the andreas/merge-doc-deploy-jobs branch November 13, 2023 17:50
@Wumpf
Copy link
Member Author

Wumpf commented Nov 13, 2023

🤞

jprochazk added a commit that referenced this pull request Nov 15, 2023
jprochazk added a commit that referenced this pull request Nov 15, 2023
…ditions" (#4231)

If we want to serialize the jobs, we can add a `needs` between them
instead. I'll do that in a separate PR

Reverts #4216
@jprochazk jprochazk mentioned this pull request Nov 15, 2023
4 tasks
jprochazk added a commit that referenced this pull request Nov 15, 2023
### What

This does the same thing as #4216,
but instead of merging them, just has them run serially by putting
dependencies between them.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/{{
pr.number }}) (if applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/{{ pr.number }})
- [Docs preview](https://rerun.io/preview/{{ pr.commit }}/docs)
<!--DOCS-PREVIEW-->
- [Examples preview](https://rerun.io/preview/{{ pr.commit }}/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md ⛴ release Related to shipping or publishing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants